Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotcue: allow setting hotcue inside active, saved loop #12623

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Hotcue: allow setting hotcue inside active, saved loop #12623

merged 2 commits into from
Jan 27, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 22, 2024 •
edited
Loading

Fixes #12618

  • activate a loop
  • seek inside the loop
  • trigger hotcue_A_activate or hotcue_A_set
    • new loop cue at loop start position
  • trigger hotcue_B_activate or hotcue_B_set
    • new hotcue at current position

Probably need to adjust some tests

@ronso0 ronso0 added the looping label Jan 22, 2024
@ronso0 ronso0 mentioned this pull request Jan 22, 2024
Closed
@ronso0 ronso0 linked an issue Jan 23, 2024 that may be closed by this pull request
simplify setting hot cue inside a loop from the GUI #12618
Closed
daschuer
daschuer requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, need to test.

src/engine/controls/cuecontrol.cpp Outdated Show resolved Hide resolved
@daschuer
Copy link
Member

I can confirm the issue and that it is fixed with this PR.

@Holzhaus
Copy link
Member

Holzhaus commented Jan 25, 2024 •
edited
Loading

Should there be a way to disable this magic? I sometimes use this to move loop cues (clone loop cue and then clear the original one).

@ronso0
Copy link
Member Author

ronso0 commented Jan 25, 2024

I sometimes use this to move loop cues

You mean store the loop in another cue?
If so, you can do it the other way around:

  • activate the saved loop 4
  • clear the cue (loop still active)
  • hit hotcue 2, done

Related: #9968

@ronso0
Copy link
Member Author

ronso0 commented Jan 25, 2024

FWIW I just filed #12645 which might also help avoid some workarounds.

@ronso0 ronso0 force-pushed the hotcue-no-redundant-loop-cue branch from 5a74988 to 11ec4b5 Compare January 26, 2024 00:30
@ronso0
Copy link
Member Author

ronso0 commented Jan 26, 2024

Wouldn't hurt to add a test for this.

@ronso0 ronso0 force-pushed the hotcue-no-redundant-loop-cue branch 3 times, most recently from 18d9af4 to 02e6236 Compare January 27, 2024 01:31
@ronso0 ronso0 force-pushed the hotcue-no-redundant-loop-cue branch from 02e6236 to f76b233 Compare January 27, 2024 01:40
@ronso0
Copy link
Member Author

ronso0 commented Jan 27, 2024

Okay, this is ready.

daschuer
daschuer approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@daschuer daschuer merged commit a51e8d6 into mixxxdj:2.4 Jan 27, 2024
13 checks passed
@ronso0 ronso0 deleted the hotcue-no-redundant-loop-cue branch January 27, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
code quality engine looping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

simplify setting hot cue inside a loop from the GUI
3 participants
@ronso0 @daschuer @Holzhaus